Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32546 )
Change subject: qcom: Add i2c driver
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
a nit more than anything, but please resolve the 1 -> BLSP_ID_ERROR thing
https://review.coreboot.org/#/c/32546/5/src/soc/qualcomm/qcs405/blsp.c
File src/soc/qualcomm/qcs405/blsp.c:
https://review.coreboot.org/#/c/32546/5/src/soc/qualcomm/qcs405/blsp.c@56
PS5, Line 56: 1
BLSP_ID_ERROR, but what's the point of bailing out _here_ (after enabling i2c halfway)?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32546
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d39d0325718fc5dd60da42eb2b87dcc4429bfc2
Gerrit-Change-Number: 32546
Gerrit-PatchSet: 5
Gerrit-Owner: Nitheesh Sekar
nsekar@codeaurora.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nitheesh Sekar
nsekar@codeaurora.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Mukesh Savaliya
msavaliy@qualcomm.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Prudhvi Yarlagadda
pyarlaga@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Thu, 06 Jun 2019 10:55:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment