Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37451 )
Change subject: AGESA,binaryPI: Move PORT80 selection to C bootblock
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37451/7/src/mainboard/lenovo/g505s/...
File src/mainboard/lenovo/g505s/romstage.c:
https://review.coreboot.org/c/coreboot/+/37451/7/src/mainboard/lenovo/g505s/...
PS7, Line 19: void board_BeforeAgesa(struct sysinfo *cb)
Can we make this a 1-liner?
File gets removed with a nearby commit.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37451
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I71aa94b33bd6f65e243724810472a440e98e0750
Gerrit-Change-Number: 37451
Gerrit-PatchSet: 7
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 05 Dec 2019 12:53:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-MessageType: comment