Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39810 )
Change subject: memranges: Change align attribute to be log2 of required alignment
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/39810/5/src/lib/memrange.c
File src/lib/memrange.c:
https://review.coreboot.org/c/coreboot/+/39810/5/src/lib/memrange.c@236
PS5, Line 236: 1ULL << ranges->align
Worth adding a helper that spits this out instead of open coding?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39810
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie4d3868cdff55b2c7908b9b3ccd5f30a5288e62f
Gerrit-Change-Number: 39810
Gerrit-PatchSet: 5
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Fri, 27 Mar 2020 06:29:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment