[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/acpi: work around Windows crash on S0ix-enabled boards

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47138 )

Change subject: soc/intel/common/acpi: work around Windows crash on S0ix-enabled boards
......................................................................

Patch Set 8:

(3 comments)

https://review.coreboot.org/c/coreboot/+/47138/8/src/soc/intel/common/block/... 
File src/soc/intel/common/block/acpi/acpi/pep.asl:

https://review.coreboot.org/c/coreboot/+/47138/8/src/soc/intel/common/block/... 
PS8, Line 23: DEVY
> Why create a named object when it is really used once (same logic as your previous CL for UUID)?

actually I did this to keep the stuff below better readable, but sure, we could move it down, too

https://review.coreboot.org/c/coreboot/+/47138/8/src/soc/intel/common/block/... 
PS8, Line 31: DUMMY
> I don't think we can use "DUMMY" here. This has to be a fully-qualified namestring as per the spec.

well, neither windows nor Linux complains 😄 (we could use CPU0 here for example). Any idea if Windows actually does something with it?

https://review.coreboot.org/c/coreboot/+/47138/8/src/soc/intel/common/block/... 
PS8, Line 32: 0,
> I know you have captured this in the comment above already. […]

will do