Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45177 )
Change subject: soc/amd/picasso: Convert DDR4 MHz to MT/s correctly ......................................................................
Patch Set 11:
(5 comments)
https://review.coreboot.org/c/coreboot/+/45177/3/src/soc/amd/picasso/dmi.c File src/soc/amd/picasso/dmi.c:
https://review.coreboot.org/c/coreboot/+/45177/3/src/soc/amd/picasso/dmi.c@2... PS3, Line 21: static uint16_t convert_speed_mhz_to_mts(uint16_t speed_mhz)
Yes, we should move this to ddr4.[c|h]. […]
Ack
https://review.coreboot.org/c/coreboot/+/45177/4/src/soc/amd/picasso/dmi.c File src/soc/amd/picasso/dmi.c:
https://review.coreboot.org/c/coreboot/+/45177/4/src/soc/amd/picasso/dmi.c@1... PS4, Line 18: den
Ack
Ack
https://review.coreboot.org/c/coreboot/+/45177/4/src/soc/amd/picasso/dmi.c@3... PS4, Line 33: #define DDR4_MIN DDR4_1600 : #define DDR4_MAX DDR4_3200 : #
Thanks for the tip.
Ack
https://review.coreboot.org/c/coreboot/+/45177/4/src/soc/amd/picasso/dmi.c@4... PS4, Line 41: static uint16_t _ddr4_tck_min_ps[] = {
Ack
Ack
https://review.coreboot.org/c/coreboot/+/45177/4/src/soc/amd/picasso/dmi.c@5... PS4, Line 58: static uint16_t _ddr4_speed_normalized_mts[] = {
I used tck because this is the value that's actually specified the spec. […]
Ack