Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41792 )
Change subject: acpi: Add support for writing UART device descriptors
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/41792/1/src/include/acpi/acpi_devic...
File src/include/acpi/acpi_device.h:
https://review.coreboot.org/c/coreboot/+/41792/1/src/include/acpi/acpi_devic...
PS1, Line 425: /* Initial Baud Rate in bytes per second. */
I’d remove the dot/period at the end.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41792
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I671ce2a499d74717d8677528c46ab3fbc1d7faf5
Gerrit-Change-Number: 41792
Gerrit-PatchSet: 1
Gerrit-Owner: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 28 May 2020 13:32:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment