Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34081 )
Change subject: device/oprom: Reduce indentation
......................................................................
Patch Set 2: Code-Review+2
Patch Set 2:
Patch Set 2:
Patch Set 2:
Testing on CB:34083 validates this.
How I could test CB:34081 and CB:34083 at the same time? I tried doing
When you did a checkout on CB:34083 you already picked up the parent commits. In contrast, a cherry-pick will only fetch the single commit.
Run 'git log --oneline' to see what you are actually building.
Thank you very much for clarifying.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34081
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iadae9221f7ea549e91cdc501155de058c51a982c
Gerrit-Change-Number: 34081
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 08 Jul 2019 05:36:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment