[coreboot-gerrit] Change in ...coreboot[master]: Kconfig: Make ramstage kconfigs dependent on CONFIG_ARCH_RAMSTAGE_X86...

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33112 )

Change subject: Kconfig: Make ramstage kconfigs dependent on CONFIG_ARCH_RAMSTAGE_X86_32/64
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/33112/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/33112/1//COMMIT_MSG@11 
PS1, Line 11: is not selected.
> ramstage exists on more than just x86 arch.

Aaron, i'm so sorry, i just missed the point that i'm touching generic code and this has to be compliant to add arch. I will create separate Konfig for stage and select those based on supported arch. In that way, i can add right dependency.
> If you want first class principles then they should be added. Making implicit assumptions about the meaning of things only makes for brittle code that is hard to maintain.