Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44254 )
Change subject: mb/google/zork: expose stop gpio for trembyle
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44254/1/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/trembyle/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44254/1/src/mainboard/google/zork/v...
PS1, Line 78: ACPI_GPIO_OUTPUT_ACTIVE_HIGH
This needs to be ACTIVE_LOW. With that, I am able to get touchscreen working again on my Trembyle.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44254
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f5da1c556ba1c6ccabf699491d3b635aa79f7c0
Gerrit-Change-Number: 44254
Gerrit-PatchSet: 2
Gerrit-Owner: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 12 Aug 2020 14:15:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment