Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38475 )
Change subject: mainboard/hatch: Fix puff DP output on cold boots ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38475/3/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/mainboard.c:
https://review.coreboot.org/c/coreboot/+/38475/3/src/mainboard/google/hatch/... PS3, Line 27: /* TODO: This can be moved to common directory */
Let's do the refactor first, then extend for puff. […]
I don't think we want to do that here as we have a fundamentally different display topology than that of Fizz. The link in the commit msg is for background on where this code was inspired from however differs in practical terms.
https://review.coreboot.org/c/coreboot/+/38475/3/src/mainboard/google/hatch/... PS3, Line 56: && !gpio_get(GPIO_DP_HPD )
This subtly changes behavior w/rt the original fizz implementation by checking HPD before timing out […]
Yes.