Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48201 )
Change subject: Makefile.inc: Fix empty output when processing C struct files in CBFS
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/48201/2/Makefile.inc
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/48201/2/Makefile.inc@339
PS2, Line 339: $$(<) --> $$(@)
Done
Done
https://review.coreboot.org/c/coreboot/+/48201/3/Makefile.inc
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/48201/3/Makefile.inc@339
PS3, Line 339: $$(<)
Yes, $(2) is ok. The output string of patchset 1 is: $$(<) --> $$(@), can output the name of . […]
I wasn't aware that $(2) is a temp file name. Let's use what you wrote here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48201
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id6a66e25d7dfe8fe6410e517593ed22a438d2f82
Gerrit-Change-Number: 48201
Gerrit-PatchSet: 3
Gerrit-Owner: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 03 Dec 2020 10:20:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Xi Chen
xixi.chen@mediatek.com
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment