Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36584 )
Change subject: [WIP] console,boot_state: Reformat state times output ......................................................................
Patch Set 4: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/36584/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36584/4//COMMIT_MSG@7 PS4, Line 7: [WIP] console,boot_state: Reformat state times output Update?
https://review.coreboot.org/c/coreboot/+/36584/4/src/console/printk.c File src/console/printk.c:
https://review.coreboot.org/c/coreboot/+/36584/4/src/console/printk.c@55 PS4, Line 55: printk(BIOS_DEBUG, "BS: " ENV_STRING " times (ms) run (unknown) (%ld)\n", this looks like it wants an update, e.g.
"BS: " ENV_STRING " times (exec / console): total (unknown) / %ld ms\n"
https://review.coreboot.org/c/coreboot/+/36584/4/src/lib/hardwaremain.c File src/lib/hardwaremain.c:
https://review.coreboot.org/c/coreboot/+/36584/4/src/lib/hardwaremain.c@256 PS4, Line 256: Having _no_ space between the asterisk and `const` seems more common (can't say that the space is uncommon, though, counts: 924 / *const>/ 170 / * const>/).