hannah.williams@dell.com has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35348 )
Change subject: Rangeley: Fix incorrect BCLK ......................................................................
Patch Set 7:
Patch Set 7:
Patch Set 7:
(1 comment)
BCLK is also a reference frequency to udelay(), fixing ACPI alone is not enough.
So get_core_fre
Agree. I was testing with 4.9 base coreboot so I did not see any other fixed BCLK dependency. Let me fix this also
Also, I get more precision by keeping the freq in KHz as I did in this code and multiplying with the ratio and then dividing by 10M. If I used get_fsb, then the return value is in MHz so the freq I would return will be 1494 instead of 1500 for example. So I would prefer to keep this code and also fix the Rangeley code in get_fsb.