Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38346 )
Change subject: mainboard: add Supermicro X9SCL/X9SCM ......................................................................
Patch Set 10: Code-Review+1
(8 comments)
https://review.coreboot.org/c/coreboot/+/38346/10/src/mainboard/supermicro/x... File src/mainboard/supermicro/x9scl/acpi/platform.asl:
PS10: /* SPDX-License-Identifier: GPL-2.0-or-later */ /* This file is part of the coreboot project. */
https://review.coreboot.org/c/coreboot/+/38346/10/src/mainboard/supermicro/x... File src/mainboard/supermicro/x9scl/acpi/superio.asl:
PS10: /* SPDX-License-Identifier: GPL-2.0-or-later */ /* This file is part of the coreboot project. */
https://review.coreboot.org/c/coreboot/+/38346/2/src/mainboard/supermicro/x9... File src/mainboard/supermicro/x9scl/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38346/2/src/mainboard/supermicro/x9... PS2, Line 41: off
It is off in the OEM firmware. […]
Any updates?
https://review.coreboot.org/c/coreboot/+/38346/10/src/mainboard/supermicro/x... File src/mainboard/supermicro/x9scl/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38346/10/src/mainboard/supermicro/x... PS10, Line 122: end Maybe pick these up?
https://review.coreboot.org/c/coreboot/+/38346/10/src/mainboard/supermicro/x... File src/mainboard/supermicro/x9scl/dsdt.asl:
PS10: /* SPDX-License-Identifier: GPL-2.0-or-later */ /* This file is part of the coreboot project. */
https://review.coreboot.org/c/coreboot/+/38346/10/src/mainboard/supermicro/x... PS10, Line 36: #include <drivers/intel/gma/acpi/default_brightness_levels.asl> Not needed anymore
https://review.coreboot.org/c/coreboot/+/38346/2/src/mainboard/supermicro/x9... File src/mainboard/supermicro/x9scl/early_init.c:
https://review.coreboot.org/c/coreboot/+/38346/2/src/mainboard/supermicro/x9... PS2, Line 63: static const u16 superio_initvals[] = {
Mostly to assure myself that I've matched the configuration to the OEM firmware closely, so as to ha […]
Ack
https://review.coreboot.org/c/coreboot/+/38346/9/src/mainboard/supermicro/x9... File src/mainboard/supermicro/x9scl/early_init.c:
https://review.coreboot.org/c/coreboot/+/38346/9/src/mainboard/supermicro/x9... PS9, Line 2: * This file is part of the coreboot project. : * : * Copyright (C) 2008-2009 coresystems GmbH : * Copyright (C) 2014 Vladimir Serbinenko : * : * This program is free software; you can redistribute it and/or : * modify it under the terms of the GNU General Public License as : * published by the Free Software Foundation; version 2 of : * the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details.
We use SPDX now
Done