Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41280 )
Change subject: security/tpm/tspi: Fix handling of white space delimited list
......................................................................
Patch Set 9: Code-Review+1
Patch Set 9: Code-Review+2
So now that there is a patch for strtok in the tree should we move forward to strtok()?
Or would you lik eto keep this for now and provide a follow-up patch once strtok() is merged?
Oh, BTW: now that you have removed the Kconfig change form this patch you should stick with the comma as separator in order to stay in line with the help text.
You can than switch back to a whitespace in the Kconfig patch.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41280
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd285162ea6e562a5bb18325a1b767ac2e4276f3
Gerrit-Change-Number: 41280
Gerrit-PatchSet: 9
Gerrit-Owner: Harshit Sharma
harshitsharmajs@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Mon, 18 May 2020 06:53:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment