Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47847 )
Change subject: soc/intel/alderlake: Update UART0 GPIO as per latest schematics
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47847/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47847/2//COMMIT_MSG@7
PS2, Line 7: latest schematics
Schematics for what?
RVP schematics with ADL SoC
This is common SoC code, shouldn't this be dependent on the pinout for the SoC?
yes, we have previous schematics with ADL interposer hence such GPIO PIN out delta.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47847
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7a193b67e22258ff600679f27955a37480ed3f0d
Gerrit-Change-Number: 47847
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 24 Nov 2020 03:48:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment