build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46587 )
Change subject: lenovo/g505s: properly program the IRQ table [WIP] ......................................................................
Patch Set 10:
(159 comments)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... File src/mainboard/lenovo/g505s/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 21: /* bus, dev | fn, {link, bitmap}, {link, bitmap}, {link, bitmap}, {link, bitmap}, slot, rfu */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 22: {0x00, (0x01 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 22: {0x00, (0x01 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 23: {0x00, (0x02 << 3) | 0x0, {{0x02, 0xdc90}, {0x03, 0xdc90}, {0x00, 0xdc90}, {0x01, 0xdc90}}, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 23: {0x00, (0x02 << 3) | 0x0, {{0x02, 0xdc90}, {0x03, 0xdc90}, {0x00, 0xdc90}, {0x01, 0xdc90}}, 0x0, 0x0}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 24: {0x00, (0x03 << 3) | 0x0, {{0x03, 0xdc90}, {0x00, 0xdc90}, {0x01, 0xdc90}, {0x02, 0xdc90}}, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 24: {0x00, (0x03 << 3) | 0x0, {{0x03, 0xdc90}, {0x00, 0xdc90}, {0x01, 0xdc90}, {0x02, 0xdc90}}, 0x0, 0x0}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 25: {0x00, (0x04 << 3) | 0x0, {{0x00, 0xdc90}, {0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}}, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 25: {0x00, (0x04 << 3) | 0x0, {{0x00, 0xdc90}, {0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}}, 0x0, 0x0}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 26: {0x00, (0x05 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}, {0x00, 0xdc90}}, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 26: {0x00, (0x05 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}, {0x00, 0xdc90}}, 0x0, 0x0}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 27: {0x00, (0x06 << 3) | 0x0, {{0x02, 0xdc90}, {0x03, 0xdc90}, {0x00, 0xdc90}, {0x01, 0xdc90}}, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 27: {0x00, (0x06 << 3) | 0x0, {{0x02, 0xdc90}, {0x03, 0xdc90}, {0x00, 0xdc90}, {0x01, 0xdc90}}, 0x0, 0x0}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 28: {0x00, (0x07 << 3) | 0x0, {{0x03, 0xdc90}, {0x00, 0xdc90}, {0x01, 0xdc90}, {0x02, 0xdc90}}, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 28: {0x00, (0x07 << 3) | 0x0, {{0x03, 0xdc90}, {0x00, 0xdc90}, {0x01, 0xdc90}, {0x02, 0xdc90}}, 0x0, 0x0}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 29: {0x01, (0x00 << 3) | 0x0, {{0x02, 0xdc90}, {0x03, 0xdc90}, {0x00, 0xdc90}, {0x01, 0xdc90}}, 0x1, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 29: {0x01, (0x00 << 3) | 0x0, {{0x02, 0xdc90}, {0x03, 0xdc90}, {0x00, 0xdc90}, {0x01, 0xdc90}}, 0x1, 0x0}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 30: {0x03, (0x00 << 3) | 0x0, {{0x03, 0xdc90}, {0x00, 0xdc90}, {0x01, 0xdc90}, {0x02, 0xdc90}}, 0x2, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 30: {0x03, (0x00 << 3) | 0x0, {{0x03, 0xdc90}, {0x00, 0xdc90}, {0x01, 0xdc90}, {0x02, 0xdc90}}, 0x2, 0x0}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 31: {0x02, (0x00 << 3) | 0x0, {{0x00, 0xdc90}, {0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}}, 0x3, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 31: {0x02, (0x00 << 3) | 0x0, {{0x00, 0xdc90}, {0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}}, 0x3, 0x0}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 32: {0x03, (0x00 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}, {0x00, 0xdc90}}, 0x4, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 32: {0x03, (0x00 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}, {0x00, 0xdc90}}, 0x4, 0x0}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 33: {0x00, (0x11 << 3) | 0x0, {{0x03, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 33: {0x00, (0x11 << 3) | 0x0, {{0x03, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 34: {0x00, (0x12 << 3) | 0x0, {{0x02, 0xdc90}, {0x01, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 34: {0x00, (0x12 << 3) | 0x0, {{0x02, 0xdc90}, {0x01, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 35: {0x00, (0x13 << 3) | 0x0, {{0x02, 0xdc90}, {0x01, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 35: {0x00, (0x13 << 3) | 0x0, {{0x02, 0xdc90}, {0x01, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 36: {0x00, (0x14 << 3) | 0x0, {{0x00, 0xdc90}, {0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}}, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 36: {0x00, (0x14 << 3) | 0x0, {{0x00, 0xdc90}, {0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}}, 0x0, 0x0}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 37: {0x00, (0x15 << 3) | 0x0, {{0x00, 0xdc90}, {0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}}, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 37: {0x00, (0x15 << 3) | 0x0, {{0x00, 0xdc90}, {0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}}, 0x0, 0x0}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 38: {0x00, (0x16 << 3) | 0x0, {{0x02, 0xdc90}, {0x01, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 38: {0x00, (0x16 << 3) | 0x0, {{0x02, 0xdc90}, {0x01, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 39: {0x00, (0x10 << 3) | 0x0, {{0x02, 0xdc90}, {0x01, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0} line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 39: {0x00, (0x10 << 3) | 0x0, {{0x02, 0xdc90}, {0x01, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0} space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... File src/mainboard/lenovo/g505s/mainboard.c:
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 30: {IOMMU_DEVFN, {PIRQ_A, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* IOMMU: 0:02.00 - ??? */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 30: {IOMMU_DEVFN, {PIRQ_A, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* IOMMU: 0:02.00 - ??? */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 31: {GFX_DEVFN, {PIRQ_A, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* VGA: 01.0 */ /* 0:01.00 - IRQ3 */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 31: {GFX_DEVFN, {PIRQ_A, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* VGA: 01.0 */ /* 0:01.00 - IRQ3 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 32: {ACTL_DEVFN,{PIRQ_NC, PIRQ_B, PIRQ_NC, PIRQ_NC}}, /* Audio: 01.1 */ /* 0:01.01 - IRQ4 */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 32: {ACTL_DEVFN,{PIRQ_NC, PIRQ_B, PIRQ_NC, PIRQ_NC}}, /* Audio: 01.1 */ /* 0:01.01 - IRQ4 */ space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 32: {ACTL_DEVFN,{PIRQ_NC, PIRQ_B, PIRQ_NC, PIRQ_NC}}, /* Audio: 01.1 */ /* 0:01.01 - IRQ4 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 33: {NB_PCIE_PORT1_DEVFN, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D}}, /* x4 PCIe: 02.1 */ /* 0:02.00 / 1:00.00 - IRQ3 */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 33: {NB_PCIE_PORT1_DEVFN, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D}}, /* x4 PCIe: 02.1 */ /* 0:02.00 / 1:00.00 - IRQ3 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 34: {NB_PCIE_PORT2_DEVFN, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D}}, /* x4 PCIe: 02.2 */ /* ??? ??? ??? */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 34: {NB_PCIE_PORT2_DEVFN, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D}}, /* x4 PCIe: 02.2 */ /* ??? ??? ??? */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 35: {NB_PCIE_PORT3_DEVFN, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D}}, /* x4 PCIe: 02.3 */ /* 0:04.00 / 2:00.00 - IRQ 3 */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 35: {NB_PCIE_PORT3_DEVFN, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D}}, /* x4 PCIe: 02.3 */ /* 0:04.00 / 2:00.00 - IRQ 3 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 36: {NB_PCIE_PORT4_DEVFN, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D}}, /* x4 PCIe: 02.4 */ /* 0:05.00 / 3:00.00 - IRQ 3 */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 36: {NB_PCIE_PORT4_DEVFN, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D}}, /* x4 PCIe: 02.4 */ /* 0:05.00 / 3:00.00 - IRQ 3 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 37: {NB_PCIE_PORT5_DEVFN, {PIRQ_B, PIRQ_C, PIRQ_D, PIRQ_A}}, /* Edge: 02.5 */ /* ??? */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 37: {NB_PCIE_PORT5_DEVFN, {PIRQ_B, PIRQ_C, PIRQ_D, PIRQ_A}}, /* Edge: 02.5 */ /* ??? */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 38: {NB_PCIE_PORT6_DEVFN, {PIRQ_A, PIRQ_C, PIRQ_D, PIRQ_B}}, /* Edge: ??? */ /* ??? */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 38: {NB_PCIE_PORT6_DEVFN, {PIRQ_A, PIRQ_C, PIRQ_D, PIRQ_B}}, /* Edge: ??? */ /* ??? */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 39: {NB_PCIE_PORT7_DEVFN, {PIRQ_A, PIRQ_C, PIRQ_D, PIRQ_B}}, /* Edge: ??? */ /* ??? */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 39: {NB_PCIE_PORT7_DEVFN, {PIRQ_A, PIRQ_C, PIRQ_D, PIRQ_B}}, /* Edge: ??? */ /* ??? */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 40: {XHCI_DEVFN, {PIRQ_C, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* XHCI: 10.0 */ /* ??? */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 40: {XHCI_DEVFN, {PIRQ_C, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* XHCI: 10.0 */ /* ??? */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 41: {SATA_DEVFN, {PIRQ_SATA, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* SATA: 11.0 */ /* 0:11.00 - IRQ7 */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 41: {SATA_DEVFN, {PIRQ_SATA, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* SATA: 11.0 */ /* 0:11.00 - IRQ7 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 42: {OHCI1_DEVFN, {PIRQ_OHCI1, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* OHCI1: 12.0 */ /* 0:12.00 - IRQ5 */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 42: {OHCI1_DEVFN, {PIRQ_OHCI1, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* OHCI1: 12.0 */ /* 0:12.00 - IRQ5 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 43: {EHCI1_DEVFN, {PIRQ_NC, PIRQ_EHCI1, PIRQ_NC, PIRQ_NC}}, /* EHCI1: 12.2 */ /* 0:12.02 - IRQ4 */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 43: {EHCI1_DEVFN, {PIRQ_NC, PIRQ_EHCI1, PIRQ_NC, PIRQ_NC}}, /* EHCI1: 12.2 */ /* 0:12.02 - IRQ4 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 44: {OHCI2_DEVFN, {PIRQ_OHCI2, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* OHCI2: 13.0 */ /* 0:13.00 - IRQ5 */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 44: {OHCI2_DEVFN, {PIRQ_OHCI2, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* OHCI2: 13.0 */ /* 0:13.00 - IRQ5 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 45: {EHCI2_DEVFN, {PIRQ_NC, PIRQ_EHCI2, PIRQ_NC, PIRQ_NC}}, /* EHCI2: 13.2 */ /* 0:13.02 - IRQ4 */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 45: {EHCI2_DEVFN, {PIRQ_NC, PIRQ_EHCI2, PIRQ_NC, PIRQ_NC}}, /* EHCI2: 13.2 */ /* 0:13.02 - IRQ4 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 46: {OHCI3_DEVFN, {PIRQ_OHCI3, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* OHCI3: 16.0 */ /* 0:16.00 - IRQ5 */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 46: {OHCI3_DEVFN, {PIRQ_OHCI3, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* OHCI3: 16.0 */ /* 0:16.00 - IRQ5 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 47: {EHCI3_DEVFN, {PIRQ_NC, PIRQ_EHCI3, PIRQ_NC, PIRQ_NC}}, /* EHCI3: 16.2 */ /* 0:16.02 - IRQ4 */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 47: {EHCI3_DEVFN, {PIRQ_NC, PIRQ_EHCI3, PIRQ_NC, PIRQ_NC}}, /* EHCI3: 16.2 */ /* 0:16.02 - IRQ4 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 48: {HDA_DEVFN, {PIRQ_HDA, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* HDA: 14.2 */ /* 0:14.02 - IRQ3 */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 48: {HDA_DEVFN, {PIRQ_HDA, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* HDA: 14.2 */ /* 0:14.02 - IRQ3 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... File src/mainboard/lenovo/g505s/mptable.h:
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 5: [0x00] = 0x03,0x04,0x05,0x07,0x01,0x02,0x06,0x08, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 5: [0x00] = 0x03,0x04,0x05,0x07,0x01,0x02,0x06,0x08, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 5: [0x00] = 0x03,0x04,0x05,0x07,0x01,0x02,0x06,0x08, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 5: [0x00] = 0x03,0x04,0x05,0x07,0x01,0x02,0x06,0x08, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 5: [0x00] = 0x03,0x04,0x05,0x07,0x01,0x02,0x06,0x08, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 5: [0x00] = 0x03,0x04,0x05,0x07,0x01,0x02,0x06,0x08, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 5: [0x00] = 0x03,0x04,0x05,0x07,0x01,0x02,0x06,0x08, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 7: [0x08] = 0x5A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 7: [0x08] = 0x5A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 7: [0x08] = 0x5A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 7: [0x08] = 0x5A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 7: [0x08] = 0x5A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 7: [0x08] = 0x5A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 7: [0x08] = 0x5A,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 9: [0x10] = 0x1F,0x1F,0x1F,0x03,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 9: [0x10] = 0x1F,0x1F,0x1F,0x03,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 9: [0x10] = 0x1F,0x1F,0x1F,0x03,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 9: [0x10] = 0x1F,0x1F,0x1F,0x03,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 9: [0x10] = 0x1F,0x1F,0x1F,0x03,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 9: [0x10] = 0x1F,0x1F,0x1F,0x03,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 9: [0x10] = 0x1F,0x1F,0x1F,0x03,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 11: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 11: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 11: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 11: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 11: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 13: [0x30] = 0x05,0x04,0x05,0x04,0x05,0x04,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 13: [0x30] = 0x05,0x04,0x05,0x04,0x05,0x04,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 13: [0x30] = 0x05,0x04,0x05,0x04,0x05,0x04,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 13: [0x30] = 0x05,0x04,0x05,0x04,0x05,0x04,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 13: [0x30] = 0x05,0x04,0x05,0x04,0x05,0x04,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 13: [0x30] = 0x05,0x04,0x05,0x04,0x05,0x04,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 13: [0x30] = 0x05,0x04,0x05,0x04,0x05,0x04,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 15: [0x40] = 0x1F, 0x07,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 15: [0x40] = 0x1F, 0x07,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 15: [0x40] = 0x1F, 0x07,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 15: [0x40] = 0x1F, 0x07,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 15: [0x40] = 0x1F, 0x07,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 15: [0x40] = 0x1F, 0x07,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 21: [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 21: [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 21: [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 21: [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 21: [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 21: [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 21: [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 23: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 23: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 23: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 23: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 23: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 23: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 23: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 25: [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 25: [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 25: [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 25: [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 25: [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 25: [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 25: [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 27: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 27: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 27: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 27: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 27: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 29: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 29: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 29: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 29: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 29: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 29: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 29: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 31: [0x40] = 0x1F, 0x13,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 31: [0x40] = 0x1F, 0x13,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 31: [0x40] = 0x1F, 0x13,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 31: [0x40] = 0x1F, 0x13,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 31: [0x40] = 0x1F, 0x13,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 31: [0x40] = 0x1F, 0x13,0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... File src/mainboard/lenovo/g505s/mptable.c:
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 77: for (byte = 0x0; byte < sizeof(picr_data_ptr); byte ++) { space prohibited before that '++' (ctx:WxB)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 83: for (byte = 0x0; byte < sizeof(intr_data_ptr); byte ++) { space prohibited before that '++' (ctx:WxB)
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 99: smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, (bus), (((dev)<<2)|(fn)), ioapic_id, (pin)) line over 96 characters
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 168: #define IO_LOCAL_INT(type, intr, apicid, pin) \ macros should not use a trailing semicolon
https://review.coreboot.org/c/coreboot/+/46587/10/src/mainboard/lenovo/g505s... PS10, Line 169: smp_write_lintsrc(mc, (type), MP_IRQ_TRIGGER_EDGE | MP_IRQ_POLARITY_HIGH, bus_isa, (intr), (apicid), (pin)); line over 96 characters