Gaggery Tsai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36685 )
Change subject: src/mb/intel/coffeelake_rvp: Add mainboard for CML-S RVP8 ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36685/3/src/mainboard/intel/coffeel... File src/mainboard/intel/coffeelake_rvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/36685/3/src/mainboard/intel/coffeel... PS3, Line 64: : config DEVICETREE : string : default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb"
I'm a bit confused. There is no devicetree.cb in baseboard. Do we want to do it in this patch? […]
okay. will do.
https://review.coreboot.org/c/coreboot/+/36685/3/src/mainboard/intel/coffeel... File src/mainboard/intel/coffeelake_rvp/chromeos_32MB.fmd:
https://review.coreboot.org/c/coreboot/+/36685/3/src/mainboard/intel/coffeel... PS3, Line 5: SI_GBE@0x81000 0x2000
Yes, this is actually essential for CFL-S/H CML-S/H RVPs. […]
Your comment is correct. Will revise it.