Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Jingle Hsu, Arthur Heymans, Morgan Jang.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50102 )
Change subject: security/intel/txt: Select TPM_STARTUP_IGNORE_POSTINIT
......................................................................
Patch Set 2:
(1 comment)
File src/security/intel/txt/Kconfig:
https://review.coreboot.org/c/coreboot/+/50102/comment/e5905d40_a7f8e6e6
PS2, Line 9: select TPM_STARTUP_IGNORE_POSTINIT
I suspect this may be specific to Xeon-SP, and possibly causes a regression on Haswell.
### Reasoning ###
Currently, the only platform that selects this option is nb/intel/ironlake, the integrated northbridge on Arrandale and Clarkdale processors. The reason is because the romstage code needs to do a CPU-only reset after configuring the QPI (QuickPath Interconnect) link.
The successor of QPI is KTI/UPI (Ultra Path Interconnect), and Xeon-SP processors have UPI links. I believe Xeon-SP FSP-M also needs to perform a CPU-only reset after configuring the UPI links; if this is the case, then this should be selected from soc/intel/xeon_sp/Kconfig instead.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50102
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I49cc3b0077b220b0ca0bfa048be1e3d3d7023b05
Gerrit-Change-Number: 50102
Gerrit-PatchSet: 2
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Comment-Date: Fri, 29 Jan 2021 11:07:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment