Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45177 )
Change subject: soc/amd/picasso: Adjust for memory Mhz fraction ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45177/2/src/soc/amd/picasso/dmi.c File src/soc/amd/picasso/dmi.c:
https://review.coreboot.org/c/coreboot/+/45177/2/src/soc/amd/picasso/dmi.c@3... PS2, Line 34: * e.g. 1333 Mhz == 1333.333 Mhz == 2666.666 MT/s == 26667 MT/s
What if it is 1466MHz which comes out to be 2933MT/s. […]
It depends on what AGESA is returning in that case. Will it be returning 1466MHz or 1467MHz? The logic below can be updated to check for 32 and round up one for the 1466Mhz case.
If reporting the speed as 2666 MT/s is acceptable, then updating mosys is the way to go.