Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39299 )
Change subject: mb/asus/p8z77-v_lx2: Add new mainboard ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/39299/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39299/3//COMMIT_MSG@7 PS3, Line 7: mb/asus/p8z77-v_lx2: Add new mainboard
Add Sandy Bridge mainboard
It's not sandy bridge though, it has an i5-3330 CPU
https://review.coreboot.org/c/coreboot/+/39299/3/src/mainboard/asus/p8z77-v_... File src/mainboard/asus/p8z77-v_lx2/acpi/platform.asl:
https://review.coreboot.org/c/coreboot/+/39299/3/src/mainboard/asus/p8z77-v_... PS3, Line 18: */
Use official comment styles? […]
This file was literally copied from here: https://github.com/coreboot/coreboot/blob/master/src/mainboard/asus/p8h61-m_...
https://review.coreboot.org/c/coreboot/+/39299/3/src/mainboard/asus/p8z77-v_... File src/mainboard/asus/p8z77-v_lx2/early_init.c:
https://review.coreboot.org/c/coreboot/+/39299/3/src/mainboard/asus/p8z77-v_... PS3, Line 48: /* Select SIO pin states. */
Remove the dot/period at the end? […]
Why?
The datasheet does not tell you which values the mainboard has to use, so I used superiotool.
https://review.coreboot.org/c/coreboot/+/39299/3/src/mainboard/asus/p8z77-v_... PS3, Line 57: /* Power RAM in S3. */
Remove dot/period at end.
Why?