Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47351 )
Change subject: mb/google/volteer/var/voema: Add memory parts and generate DRAM IDs
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47351/2/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/voema/memory/dram_id.generated.txt:
PS2:
what happened here? you should only have 3 entries and not repeat IDs.
This file contains list of all memory parts used and the ID to assign to that part. This is how the spd_tool generates the file.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47351
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic832155448fb07152b906aa04ca49d384ec47b34
Gerrit-Change-Number: 47351
Gerrit-PatchSet: 2
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 10 Nov 2020 00:32:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Gerrit-MessageType: comment