Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: restructure x11ssh-tf to represent a x11 board series ......................................................................
Patch Set 29:
I admit I did not read through all the commit messages for argumentation why you want the directory renamed.
That's the problem here ;-) The discussion is going on since weeks.
Use of variants/ is welcome for sure for similar board ports. While the base directory name can be somewhat arbitrary, including the socket type 'lga1151-series' there is kind of introducing a completely new naming scheme; I am not so convinced that we want that. Sometimes we have just kept the name of the first ported board as the base directory name, IMHO that would have been just fine here.
I really do NOT want to discuss this another time. We already discussed this a) 4 times on gerrit and b) multiple times in IRC. We agreed on 'lga1151-series'.
Sometimes we have just kept the name of the first ported board
This would be very bad because there are about 20 boards we can support in this series.
So this is already decided? Still I dont think it is a good idea. But I wont block it if you want to let it slip into the tree thats fine with me.
In any case, there is no rule for these names yet and this is the wrong forum to discuss new rules. Yes, in some cases we kept the name of the first board. But sometimes the vendor picked a different name. And we already have cases of made up schemes, e.g. librem_skl. I don't think it matters that much (hey, I can type x11<tab> and have the correct path, isn't that enough?).
If somebody wants to enforce a scheme, please discuss that on the mailing list, and be prepared to write patches to make existing ports compliant.
Aaaand, would somebody break the commit message at 72 chars, please? It's unreadable in Gerrit when not viewed full-screen. Hence, I didn't read it.