Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46055 )
Change subject: security/intel/txt: Use `smm_region()` to get TSEG base
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46055/1/src/security/intel/txt/rams...
File src/security/intel/txt/ramstage.c:
https://review.coreboot.org/c/coreboot/+/46055/1/src/security/intel/txt/rams...
PS1, Line 239: tseg_base
Code assumes this is specified in MiB units, and this will overflow unless shifted accordingly.
Ack
https://review.coreboot.org/c/coreboot/+/46055/1/src/security/intel/txt/rams...
PS1, Line 255: (tseg_base * MiB)
just `tseg_base`
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46055
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4b3dcbc61854fbdd42275bf9456eaa5ce783e8aa
Gerrit-Change-Number: 46055
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 06 Oct 2020 09:55:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment