Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42576 )
Change subject: mb/asus/p2b: only select HAVE_MP_TABLE for D and DS variant ......................................................................
Patch Set 1:
When I did the variant conversion, I add mptable.c as a ramstage compile unit via Makefile.inc based on GENERATE_MP_TABLE, following the pattern of other boards. If you just call write_smp_table(), and it isn't defined (in mptable.c or elsewhere) the build will fail. No override needed. Let mainboard be responsible for providing mptable.c. (This does not preclude sharing if appropriate.) I hope this points you in the right direction.
Oh, i should have looked if there are new comments after i re-did the change. Yeah, you're right; didn't look at the Makefile.inc
But yes, this patch is still wrong.
I agree.