Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35732 )
Change subject: intel/fsp_baytrail: Rename from xx_DEV_FUNC
......................................................................
Patch Set 1:
Patch Set 1:
With this change, do you had in mind to find out how much of these devices are rally used adn let Jenkins do the job? You will for sure abandon it once you get the info, right?
Why would it break on jenkins when I renamed all occasions?
Intel adopted xx_DEVFN_xx naming for macros expanding to PCI_DEVFN() starting with apollolake, why should we have older soc/ use different naming scheme?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35732
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id78e594ae6490d39df76317f8fc3381fe681dd6f
Gerrit-Change-Number: 35732
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 01 Oct 2019 05:14:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment