Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48698 )
Change subject: arch/x86: Pass GNVS as parameter to SMM module
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/48698/4/src/cpu/x86/smm/smm_module_...
File src/cpu/x86/smm/smm_module_handler.c:
https://review.coreboot.org/c/coreboot/+/48698/4/src/cpu/x86/smm/smm_module_...
PS4, Line 139: gnvs = (void *)(uintptr_t)smm_runtime->gnvs_ptr;
Hmmm, platforms had a call to `smm_points_to_smram` here, but I'm not sure if implementing this check here is easily doable... Thoughts?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48698
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9d7417462830443f9c96273d2cc326cbcc3b17dd
Gerrit-Change-Number: 48698
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Michal Motyl
michalx.motyl@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 03 Jan 2021 11:53:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment