John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39785 )
Change subject: soc/intel/tigerlake: Configure TCSS xHCI power management ......................................................................
Patch Set 2:
(9 comments)
https://review.coreboot.org/c/coreboot/+/39785/1/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/tcss.asl:
https://review.coreboot.org/c/coreboot/+/39785/1/src/soc/intel/tigerlake/acp... PS1, Line 62: Store (ShiftLeft(SS1, 1), Local0) // S1
trailing whitespace
Done
https://review.coreboot.org/c/coreboot/+/39785/1/src/soc/intel/tigerlake/acp... PS1, Line 63: Or (Local0, ShiftLeft(SS2, 2), Local0) // S2
trailing whitespace
Done
https://review.coreboot.org/c/coreboot/+/39785/1/src/soc/intel/tigerlake/acp... PS1, Line 64: Or (Local0, ShiftLeft(SS3, 3), Local0) // S3
trailing whitespace
Done
https://review.coreboot.org/c/coreboot/+/39785/1/src/soc/intel/tigerlake/acp... PS1, Line 65: Or (Local0, ShiftLeft(SS4, 4), Local0) // S4
trailing whitespace
Done
https://review.coreboot.org/c/coreboot/+/39785/1/src/soc/intel/tigerlake/acp... PS1, Line 239: * Result will be updated in DATA[1:0]
trailing whitespace
Done
https://review.coreboot.org/c/coreboot/+/39785/1/src/soc/intel/tigerlake/acp... PS1, Line 325: } Else {
trailing whitespace
Done
https://review.coreboot.org/c/coreboot/+/39785/1/src/soc/intel/tigerlake/acp... PS1, Line 402: /* Drop this method due to it is alredy exit D3 cold */
'alredy' may be misspelled - perhaps 'already'?
Ack
https://review.coreboot.org/c/coreboot/+/39785/1/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/tcss_xhci.asl:
https://review.coreboot.org/c/coreboot/+/39785/1/src/soc/intel/tigerlake/acp... PS1, Line 16: /*
trailing whitespace
Done
https://review.coreboot.org/c/coreboot/+/39785/1/src/soc/intel/tigerlake/acp... PS1, Line 121: * Power resource for wake
trailing whitespace
Done