Attention is currently required from: Yi Chou.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79800?usp=email )
Change subject: libpayload: Move back the ttb_buffer section
......................................................................
Patch Set 6:
(1 comment)
File payloads/libpayload/arch/arm64/mmu.c:
https://review.coreboot.org/c/coreboot/+/79800/comment/fccaf6a9_7bd7268a :
PS6, Line 47: * Please contact: jwerner@chromium.org or yich@chromium.org */
Sorry, my review comes a bit late, but why don't we change this to `__attribute__((__section__(". […]
We can, it's just redundant. If you think that would make it safer I'm fine with putting it in explicitly too. We still need to have a comment explaining why it's there, though.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79800?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9bb08878dd4be01d9ed3f96933f774dd6296f76e
Gerrit-Change-Number: 79800
Gerrit-PatchSet: 6
Gerrit-Owner: Yi Chou
yich@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Yidi Lin
yidilin@google.com
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Yi Chou
yich@google.com
Gerrit-Comment-Date: Tue, 16 Jan 2024 18:43:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment