Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33783
Change subject: device/oprom: Fix coding standard problem from // to /* */ ......................................................................
device/oprom: Fix coding standard problem from // to /* */
Change-Id: I321d9e54fee42cd9f0cff5f962246934209577f7 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/device/oprom/realmode/x86.c 1 file changed, 17 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/33783/1
diff --git a/src/device/oprom/realmode/x86.c b/src/device/oprom/realmode/x86.c index a7631a1..80455a5 100644 --- a/src/device/oprom/realmode/x86.c +++ b/src/device/oprom/realmode/x86.c @@ -104,9 +104,9 @@
printk(BIOS_INFO, "Oops, exception %d while executing option rom\n", regs->vector); - x86_exception(regs); // Call coreboot exception handler + x86_exception(regs); /* Call coreboot exception handler */
- return 0; // Never really returns + return 0; /* Never really returns */ }
static int intXX_unknown_handler(void) @@ -238,9 +238,9 @@ static u8 vbe_set_mode(vbe_mode_info_t * mi) { printk(BIOS_DEBUG, "VBE: Setting VESA mode %04x\n", mi->video_mode); - // request linear framebuffer mode + /* request linear framebuffer mode */ mi->video_mode |= (1 << 14); - // request clearing of framebuffer + /* request clearing of framebuffer */ mi->video_mode &= ~(1 << 15); realmode_interrupt(0x10, VESA_SET_MODE, mi->video_mode, 0x0000, 0x0000, 0x0000, 0x0000); @@ -393,8 +393,9 @@ ip, cs, flags); #endif
- // Fetch arguments from the stack and put them to a place - // suitable for the interrupt handlers + /* Fetch arguments from the stack and put them to a place + * suitable for the interrupt handlers + */ X86_EAX = eax; X86_ECX = ecx; X86_EDX = edx; @@ -409,15 +410,16 @@ X86_CS = cs; X86_EFLAGS = flags;
- // Call the interrupt handler for this int# + /* Call the interrupt handler for this int# */ ret = intXX_handler[intnumber]();
- // Put registers back on the stack. The assembler code - // will later pop them. - // What happens here is that we force (volatile!) changing - // the values of the parameters of this function. We do this - // because we know that they stay alive on the stack after - // we leave this function. Don't say this is bollocks. + /* Put registers back on the stack. The assembler code + * will later pop them. + * What happens here is that we force (volatile!) changing + * the values of the parameters of this function. We do this + * because we know that they stay alive on the stack after + * we leave this function. Don't say this is bollocks. + */ *(volatile u32 *)&eax = X86_EAX; *(volatile u32 *)&ecx = X86_ECX; *(volatile u32 *)&edx = X86_EDX; @@ -428,10 +430,10 @@
/* Pass success or error back to our caller via the CARRY flag */ if (ret) { - flags &= ~1; // no error: clear carry + flags &= ~1; /* no error: clear carry */ }else{ printk(BIOS_DEBUG,"int%02x call returned error.\n", intnumber); - flags |= 1; // error: set carry + flags |= 1; /* error: set carry */ } *(volatile u16 *)&stackflags = flags;