Attention is currently required from: Paul Menzel.
Ruihai Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78958?usp=email )
Change subject: mb/google/geralt: Disable SD card support for Ciri
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78958/comment/6fc5407c_dc489bba :
PS4, Line 7: mb/google/geralt: Disable SD card support for Ciri
Is the prefix variant scheme of `mb/google/geralt/var/ciri` superseded?
I don't know if coreboot upstream has documentation describing this.
But I found a doc in chromium about working with coreboot upstream [1], which state below:
```
The prefix for the title should be an abbreviated path to the edited file
```
[1] https://chromium.googlesource.com/chromiumos/docs/+/HEAD/firmware/coreboot_u...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78958?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id4e021e7896d093560f39c40573ac616d76438c2
Gerrit-Change-Number: 78958
Gerrit-PatchSet: 4
Gerrit-Owner: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: cong yang
yangcong5@huaqin.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Fri, 17 Nov 2023 09:43:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment