build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45987 )
Change subject: amd/picasso/verstage: replace rsa accel with modexp ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/45987/2/src/soc/amd/picasso/psp_ver... File src/soc/amd/picasso/psp_verstage/vboot_crypto.c:
https://review.coreboot.org/c/coreboot/+/45987/2/src/soc/amd/picasso/psp_ver... PS2, Line 131: for(i = 0; i < key->arrsize; i++) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45987/2/src/soc/amd/picasso/psp_ver... PS2, Line 131: for(i = 0; i < key->arrsize; i++) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/45987/2/src/soc/amd/picasso/psp_ver... PS2, Line 150: for(i = 0; i < key->arrsize; i++) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/45987/2/src/soc/amd/picasso/psp_ver... PS2, Line 150: for(i = 0; i < key->arrsize; i++) { braces {} are not necessary for single statement blocks