Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47902 )
Change subject: mb/google/zork: Update SPD table for Shuboz
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47902/1/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/shuboz/spd/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/47902/1/src/mainboard/google/zork/v...
PS1, Line 10: 0
Is there a bug where this was discussed?
Hi Furquan,
We try remove Fixed ID to generate SPD table, the result is as follows:
SPD_SOURCES =
SPD_SOURCES += ddr4-spd-1.hex # ID = 0(0b0000) Parts = MT40A512M16TB-062E:J, H5AN8G6NCJR-XNC
SPD_SOURCES += ddr4-spd-7.hex # ID = 1(0b0001) Parts = MT40A1G16KD-062E:E, K4AAG165WA-BCWE
We think the result does not meet, so add Fixed ID to generate, or we need to change to this result?
Thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47902
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f5f875daab58343f1cc8a9327ea128ba5e1f050
Gerrit-Change-Number: 47902
Gerrit-PatchSet: 2
Gerrit-Owner: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-Comment-Date: Thu, 26 Nov 2020 03:20:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-MessageType: comment