Attention is currently required from: Nico Huber, Sridhar Siricilla, Patrick Rudolph.
Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61380 )
Change subject: soc/intel/common: Add support to control coreboot and Intel SoC features
......................................................................
Patch Set 14: Code-Review+2
(1 comment)
File src/soc/intel/common/basecode/debug/debug_feature.c:
https://review.coreboot.org/c/coreboot/+/61380/comment/64724724_1bff0b7a
PS14, Line 9: SI_DESC_OEM_SECTION_OFFSET
Would be good if we can have and entry like SI_DEBUG in SI_DESC in flashmap. This would be easy to reference in tools as well which understand the FMAP.
but, you can do that as another patch
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61380
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5ba40926bd9ad909654f152e48cdd648b28afd62
Gerrit-Change-Number: 61380
Gerrit-PatchSet: 14
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 10 Mar 2022 10:44:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment