Nick Vaccaro has submitted this change. ( https://review.coreboot.org/c/coreboot/+/56973 )
Change subject: mb/google/dedede/var/cappy2: Fix the DUT with cirrus codec PLT fail ......................................................................
mb/google/dedede/var/cappy2: Fix the DUT with cirrus codec PLT fail
irq(ACPI_IRQ_LEVEL_LOW) -> ACPI_DESCRIPTOR_INTERRUPT -> IO-APIC, will assert interrupt frequently;
irq_gpio(ACPI_GPIO_IRQ_EDGE_BOTH) -> ACPI_DESCRIPTOR_GPIO -> INT34C8; will not assert interrupt frequently;
Because IRQ configuration can't be setted to both EDGE trigger.
BUG=b:195635555 BRANCH=dedede TEST=Cirrus audio codec PLT pass
Signed-off-by: Sunwei Li lisunwei@huaqin.corp-partner.google.com Change-Id: I65bca519f75af84848284f039b6ad67cb1887823 Reviewed-on: https://review.coreboot.org/c/coreboot/+/56973 Reviewed-by: Karthik Ramasubramanian kramasub@google.com Reviewed-by: Weimin Wu wuweimin@huaqin.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/dedede/variants/cappy2/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved Weimin Wu: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/dedede/variants/cappy2/overridetree.cb b/src/mainboard/google/dedede/variants/cappy2/overridetree.cb index 2635b34..1194a2c 100644 --- a/src/mainboard/google/dedede/variants/cappy2/overridetree.cb +++ b/src/mainboard/google/dedede/variants/cappy2/overridetree.cb @@ -109,7 +109,7 @@ end end chip drivers/i2c/cs42l42 - register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D16_IRQ)" + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_D16)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_H16)" register "ts_inv" = "true" register "ts_dbnc_rise" = "RISE_DEB_1000_MS"