[coreboot-gerrit] Change in coreboot[master]: sconfig: Allow chipset to provide a base devicetree

[Duncan Laurie (Code Review)]

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44037 )

Change subject: sconfig: Allow chipset to provide a base devicetree
......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44037/9/util/sconfig/main.c 
File util/sconfig/main.c:

https://review.coreboot.org/c/coreboot/+/44037/9/util/sconfig/main.c@713 
PS9, Line 713: base_root_dev
> > base_root_dev is the chipset tree when it exists, but only if it exists.. […]

An alias added in override tree isn't getting caught as a duplicate so it just ends up getting assigned to the first one silently.  https://review.coreboot.org/c/coreboot/+/45878/2/src/mainboard/google/voltee...

Is actually an issue from the previous alias patch where it does that check in new_device, this is different since adding a device reference in an override doesn't really make sense in the first place.  Maybe 'ref' in override (or 'last' tree in a generic situation) should be rejected.