Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79828?usp=email )
(
2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: cpu/x86/smi_trigger: use call_smm ......................................................................
cpu/x86/smi_trigger: use call_smm
Use call_smm instead of writing the command number directly to the APMC SMI command IO port.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: Iefbdb3d17932d6db6a17b5771436ede220c714fb Reviewed-on: https://review.coreboot.org/c/coreboot/+/79828 Reviewed-by: Matt DeVillier matt.devillier@amd.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/cpu/x86/smi_trigger.c 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/cpu/x86/smi_trigger.c b/src/cpu/x86/smi_trigger.c index 5c63b9e..52c7247 100644 --- a/src/cpu/x86/smi_trigger.c +++ b/src/cpu/x86/smi_trigger.c @@ -3,6 +3,7 @@ #include <arch/io.h> #include <console/console.h> #include <cpu/x86/smm.h> +#include <smm_call.h> #include <stdint.h>
static void apmc_log(const char *fn, u8 cmd) @@ -38,7 +39,7 @@ apmc_log(__func__, cmd);
/* Now raise the SMI. */ - outb(cmd, pm_acpi_smi_cmd_port()); + call_smm(cmd, 0, NULL);
printk(BIOS_DEBUG, "APMC done.\n"); return CB_SUCCESS;