Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46090 )
Change subject: mb/google/dedede: refactor DPTF section for simpler overrides ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46090/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/drawcia/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46090/2/src/mainboard/google/dedede... PS2, Line 78: [0] = DPTF_PASSIVE(CPU, CPU, 80, 1000), : [1] = DPTF_PASSIVE(CPU, TEMP_SENSOR_0, 70, 4000), : [2] = DPTF_PASSIVE(CPU, TEMP_SENSOR_1, 75, 1000), : [3] = DPTF_PASSIVE(CHARGER, TEMP_SENSOR_2, 75, 5000), : [4] = DPTF_PASSIVE(CPU, TEMP_SENSOR_3, 60, 1000)
Ack
Done
https://review.coreboot.org/c/coreboot/+/46090/2/src/mainboard/google/dedede... PS2, Line 102: .pl2 = { : .min_power = 6000, : .max_power = 20000, : .time_window_min = 1 * MSECS_PER_SEC, : .time_window_max = 1 * MSECS_PER_SEC, : .granularity = 1000, : }
Thanks Tim for this info. For the same reason, I have specified both pl1 and pl2 above.
Done