Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48429 )
Change subject: cbfs: Skip mcache in post-RAM stages before CBMEM is online
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48429/1/src/lib/cbfs.c
File src/lib/cbfs.c:
https://review.coreboot.org/c/coreboot/+/48429/1/src/lib/cbfs.c@31
PS1, Line 31: ENV_ROMSTAGE_OR_BEFORE
Wouldn't this cause romstage to always skip the lookup? Isn't cbmem_online() check sufficient here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48429
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icf6d1a1288cb243d0c4c893cc58251687e2873b0
Gerrit-Change-Number: 48429
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 08 Dec 2020 01:41:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment