Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41224 )
Change subject: mb/asus/.../p3b-f: Enable flashrom in ramstage final ......................................................................
Patch Set 1:
(4 comments)
Why can’t flashrom run the enable routine itself, that means, why is it needed in firmware?
https://review.coreboot.org/c/coreboot/+/41224/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41224/1//COMMIT_MSG@9 PS1, Line 9: as As
https://review.coreboot.org/c/coreboot/+/41224/1//COMMIT_MSG@10 PS1, Line 10: trick no longer works after introducing ACPI support, add a mainboard Why doesn’t it work anymore with ACPI support?
https://review.coreboot.org/c/coreboot/+/41224/1/src/mainboard/asus/p2b/vari... File src/mainboard/asus/p2b/variants/p3b-f/mainboard.c:
https://review.coreboot.org/c/coreboot/+/41224/1/src/mainboard/asus/p2b/vari... PS1, Line 23: faile failed
https://review.coreboot.org/c/coreboot/+/41224/1/src/mainboard/asus/p2b/vari... PS1, Line 23: printk(BIOS_INFO," faile"); The failed message should be error or even warning level.