Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39865 )
Change subject: soc/intel/tigerlake: Reorganize memory initialization support ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39865/2/src/soc/intel/tigerlake/inc... File src/soc/intel/tigerlake/include/soc/meminit_tgl.h:
https://review.coreboot.org/c/coreboot/+/39865/2/src/soc/intel/tigerlake/inc... PS2, Line 44: uintptr_t data_ptr; : size_t data_len; These need to be in a struct together.
https://review.coreboot.org/c/coreboot/+/39865/2/src/soc/intel/tigerlake/mem... File src/soc/intel/tigerlake/meminit_tgl.c:
https://review.coreboot.org/c/coreboot/+/39865/2/src/soc/intel/tigerlake/mem... PS2, Line 40: Reserved9 Do we have a bug to see if we can get this one opened up?
https://review.coreboot.org/c/coreboot/+/39865/2/src/soc/intel/tigerlake/mem... PS2, Line 170: d nit: %u, index is unsigned