Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: restructure x11ssh-tf to represent a x11 board series ......................................................................
Patch Set 31:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35426/28//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35426/28//COMMIT_MSG@10 PS28, Line 10: differentc
different
Done
https://review.coreboot.org/c/coreboot/+/35426/28//COMMIT_MSG@13 PS28, Line 13: 35427
It’s not marked up by Gerrit. Please use the Change-Id.
Done
https://review.coreboot.org/c/coreboot/+/35426/28//COMMIT_MSG@9 PS28, Line 9: Most of the X11 boards with socket LGA1151 are basically the same boards with just some minor : differences like differentc NICs (1 GbE, 10 GbE), number of NICs / PCIe ports etc. : There are about 20 boards that can be added, if there is a community for testing. : : To be able to add more x11 boards easily like x11ssm (see CR 35427) this restructures the : x11ssh tree to represent a "X11 LGA1151 series". There were multiple suggestions for the : structure like grouping by series (x10, x11, x...), grouping by chipset or by cpu family. : It turned out that there are some "X11 series" boards that are completely different. : Grouping by chipset or cpu family suffers from the same problem. This is why finally we : agreed on grouping by series and socket ("X11 LGA1151 series"). : : The structure uses the common baseboard scheme, while there is no "real" baseboard we : know of. By checking images, comparing logs etc. we came to the conclusion that Supermicro : does have some base layout which is only modified a bit for the different boards. : : X11SSH-TF was moved to the variants/ folder with it's gpio.h. As we expect the other : boards to have mostly the same device tree, there is a common devicetree that gets : overridden by each variant's overridetree. : : Besides that some very minor modifications happened (formatting, fixing comments).
For commit messages the text width limit is 75 characters.
Done
https://review.coreboot.org/c/coreboot/+/35426/28/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/Kconfig:
https://review.coreboot.org/c/coreboot/+/35426/28/src/mainboard/supermicro/x... PS28, Line 19: default "Supermicro_X11_LGA1151_SERIES"
I'd say we should use vendor string here, but it is […]
yup, that's why I looked what other boards do and found that this is the best solution here :)