Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40623 )
Change subject: Revert "soc/mediatek/mt8183: Force retraining memory if requested" ......................................................................
Patch Set 2:
Patch Set 2:
Hi Julius, I think VB2_RECOVERY_TRAIN_AND_REBOOT is needed. It is the equivalent command to 'crossystem recovery_request=0xc4', which we used in factory process to enforce DRAM training ( https://chromium.googlesource.com/chromiumos/platform/factory/+/HEAD/py/test... ), for both x86 and ARM.
Without this, we can't enforce re-training in manufacturing process.
It is not as much to force retraining. This command was added on x86 to ensure that recovery mode training data is generated and saved for future uses. If that data already exists, there is no need to force training. That is the primary reason why Julius pushed this revert.