Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38522 )
Change subject: x86/acpi_device: Allow acpi_device_add_power_res params as optional
......................................................................
Patch Set 3:
Patch Set 2:
(1 comment)
Ah right. Sorry got you now, you meant the _ON, _OFF methods can wind up just empty. Fixed now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38522
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8053d7a080dfed898400c0994bcea492c826fe3d
Gerrit-Change-Number: 38522
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Daniel Kurtz
djkurtz@google.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 30 Jan 2020 02:22:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment