Aaron Durbin (adurbin@chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10175
-gerrit
commit 95fb3e7926cf493b3e70b36f2f9a33fb421df983 Author: Aaron Durbin adurbin@chromium.org Date: Mon May 11 14:19:37 2015 -0500
imd: don't recover on limit == 0
If the limit of the large starting region was set with a NULL pointer then the limit field will be 0. If the limit is zero then no attempt to recover is necessary as there is no region to recover.
This prevented an early call cbmem_find() from hanging a rambi device. The config was with vboot enabled and was way before memory init in the sequence.
Change-Id: I7163d93c31ecef2c108a6dde0206dc0b6f158b5c Signed-off-by: Aaron Durbin adurbin@chromium.org --- src/lib/imd.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/src/lib/imd.c b/src/lib/imd.c index 02fc2b3..612e3f1 100644 --- a/src/lib/imd.c +++ b/src/lib/imd.c @@ -411,6 +411,9 @@ void imd_handle_init_partial_recovery(struct imd *imd) struct imd_root_pointer *rp; struct imdr *imdr;
+ if (imd->lg.limit == 0) + return; + imd_handle_init(imd, (void *)imd->lg.limit);
/* Initialize root pointer for the large regions. */