Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37178 )
Change subject: soc/amd/common/block/acpimmio: fix ACPIMMIO decode enable function ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37178/5/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/acpimmio_map.h:
https://review.coreboot.org/c/coreboot/+/37178/5/src/soc/amd/common/block/in... PS5, Line 26: * enable the decode in PMx24 instead. All discrete FCHs and the Kabini
Doesn't the comment here specifically say fam14-15tn-16kn do not use ACPIMMIO_DECODE_REGISTER 0x4 an […]
Only SB800 uses PM register 0x24. However, that southbridge has its own early implementation of decode_enable thus not using the enable function provided by this common block. I wonder if this is the correct place to put CONFIG() macros and separate the implementation