Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46658 )
Change subject: soc/intel/xeon_sp: Use common cpu/intel romstage entry
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46658/9/src/soc/intel/xeon_sp/Kconf...
File src/soc/intel/xeon_sp/Kconfig:
https://review.coreboot.org/c/coreboot/+/46658/9/src/soc/intel/xeon_sp/Kconf...
PS9, Line 58: select NO_SMM
Why do you add this? What does it to do with this commit subject?
The common cpu/intel/car/romstage.c code has different codepaths depending on CONFIG_TSEG. So in this CL CONFIG_NO_SMM needs to be explicitly set. It is removed in one of the next CL when SMM is properly set up. I'll update the commit message to reflect this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46658
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie85df5d244fa37c41f0b3177ca325c607fa54593
Gerrit-Change-Number: 46658
Gerrit-PatchSet: 9
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rocky Phagura
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-Comment-Date: Fri, 06 Nov 2020 18:28:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Gerrit-MessageType: comment