Aamir Bohra has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39341 )
Change subject: soc/intel/tigerlake: Set dynamic pad termination for SD CMD pin ......................................................................
soc/intel/tigerlake: Set dynamic pad termination for SD CMD pin
Change-Id: I1bdb2d8cf2b16cb43f39927fe616d177a9e54f48 Signed-off-by: Aamir Bohra aamir.bohra@intel.com --- M src/soc/intel/tigerlake/fsp_params_jsl.c 1 file changed, 9 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/39341/1
diff --git a/src/soc/intel/tigerlake/fsp_params_jsl.c b/src/soc/intel/tigerlake/fsp_params_jsl.c index 8eb3fba..0e196ac 100644 --- a/src/soc/intel/tigerlake/fsp_params_jsl.c +++ b/src/soc/intel/tigerlake/fsp_params_jsl.c @@ -26,6 +26,8 @@ #include <soc/soc_chip.h> #include <string.h>
+#define DYNAMIC_PAD_TERMINATION 0x1F + static const pci_devfn_t serial_io_dev[] = { PCH_DEVFN_I2C0, PCH_DEVFN_I2C1, @@ -143,7 +145,13 @@ }
/* SDCard related configuration */ - params->ScsSdCardEnabled = pcidev_path_on_root(PCH_DEVFN_SDCARD) ? dev->enabled : 0; + dev = pcidev_path_on_root(PCH_DEVFN_SDCARD); + if (!dev) { + params->ScsSdCardEnabled = 0; + } else { + params->ScsSdCardEnabled = dev->enabled; + params->SdCardGpioCmdPadTermination = DYNAMIC_PAD_TERMINATION; + }
params->Device4Enable = config->Device4Enable;