Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35077 )
Change subject: security/vboot: Decouple measured boot from verified boot ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35077/5/src/lib/cbfs.c File src/lib/cbfs.c:
https://review.coreboot.org/c/coreboot/+/35077/5/src/lib/cbfs.c@330 PS5, Line 330: #if !CONFIG(VBOOT) && CONFIG(VBOOT_MEASURED_BOOT)
Yes, I meant bootblock_main_with_timestamp(). I wasn't aware that there are still platforms not using C_ENVIRONMENT_BOOTBLOCK... do you think it is important to support this feature there? You can assume that all future boards should be using it.
According to my understanding, C_ENVIRONMENT_BOOTBLOCK is on the direction of bootblock's evolution, buts sadly, the platforms I am currently owning and using have not migrated to C_ENVIRONMENT_BOOTBLOCK yet, so I may have to wait for it, or start trying the second variant somehow ;-)
https://review.coreboot.org/c/coreboot/+/35077/5/src/security/vboot/Kconfig File src/security/vboot/Kconfig:
https://review.coreboot.org/c/coreboot/+/35077/5/src/security/vboot/Kconfig@... PS5, Line 24: verified voot
Please don't replace perfectly fine help text with typos. […]
Fixed as you pointed out.