Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42112 )
Change subject: spi: Add struct spi_flash_bpbits, a common rep. for block protection ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42112/2/src/include/spi_flash.h File src/include/spi_flash.h:
https://review.coreboot.org/c/coreboot/+/42112/2/src/include/spi_flash.h@73 PS2, Line 73: * srl srp Do we need to carry this naming distinction through our code? I think Winbond just renamed these at some point for all their newer chips and it's not really related to the type (e.g. I also found a W25Q128JV that uses SRP/SRL notation but allows the permanent protection). I would just stick with the SRP0/SRP1 notation everywhere to avoid adding confusion where it's not really needed.